[
https://issues.apache.org/jira/browse/HDDS-1827?focusedWorklogId=298377&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-298377
]
ASF GitHub Bot logged work on HDDS-1827:
----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Aug/19 02:28
Start Date: 21/Aug/19 02:28
Worklog Time Spent: 10m
Work Description: hanishakoneru commented on pull request #1130:
HDDS-1827. Load Snapshot info when OM Ratis server starts.
URL: https://github.com/apache/hadoop/pull/1130#discussion_r315976601
##########
File path:
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/snapshot/TestOMRatisSnapshotInfo.java
##########
@@ -0,0 +1,63 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with this
+ * work for additional information regarding copyright ownership. The ASF
+ * licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ * <p>
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * <p>
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
under
+ * the License.
+ */
+
+package org.apache.hadoop.ozone.om.snapshot;
+
+import org.apache.hadoop.ozone.om.ratis.OMRatisSnapshotInfo;
+import org.junit.Assert;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.rules.TemporaryFolder;
+
+import java.io.File;
+
+/**
+ * Tests {@link org.apache.hadoop.ozone.om.ratis.OMRatisSnapshotInfo}
+ */
+public class TestOMRatisSnapshotInfo {
+
+ @Rule
+ public TemporaryFolder folder = new TemporaryFolder();
+
+ @Test
+ public void testSaveAndLoadSnapshotInfo() throws Exception {
+ File rootDir = folder.newFolder();
+ OMRatisSnapshotInfo omRatisSnapshotInfo = new OMRatisSnapshotInfo(rootDir);
+
+ // Initially term and index should be 0
+ Assert.assertEquals(0, omRatisSnapshotInfo.getTerm());
+ Assert.assertEquals(-1, omRatisSnapshotInfo.getIndex());
+
+ int snapshotIndex = 10;
+ int termIndex = 2;
+
+ // Save snapshotInfo to disk
+ omRatisSnapshotInfo.updateTerm(termIndex);
+ omRatisSnapshotInfo.saveRatisSnapshotToDisk(snapshotIndex);
+
+ Assert.assertEquals(2, omRatisSnapshotInfo.getTerm());
+ Assert.assertEquals(10, omRatisSnapshotInfo.getIndex());
Review comment:
These were random values I set for the term and index. I updated to use
Random.nextInt() instead of constant value.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 298377)
Time Spent: 2h 20m (was: 2h 10m)
> Load Snapshot info when OM Ratis server starts
> ----------------------------------------------
>
> Key: HDDS-1827
> URL: https://issues.apache.org/jira/browse/HDDS-1827
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Reporter: Hanisha Koneru
> Assignee: Hanisha Koneru
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> When Ratis server is starting it looks for the latest snapshot to load it.
> Even though OM does not save snapshots via Ratis, we need to load the saved
> snaphsot index into Ratis so that the LogAppender knows to not look for logs
> before the snapshot index. Otherwise, Ratis will replay the logs from
> beginning every time it starts up.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
