[ 
https://issues.apache.org/jira/browse/HDDS-1827?focusedWorklogId=298378&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-298378
 ]

ASF GitHub Bot logged work on HDDS-1827:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 21/Aug/19 02:29
            Start Date: 21/Aug/19 02:29
    Worklog Time Spent: 10m 
      Work Description: hanishakoneru commented on pull request #1130: 
HDDS-1827. Load Snapshot info when OM Ratis server starts.
URL: https://github.com/apache/hadoop/pull/1130#discussion_r315976747
 
 

 ##########
 File path: 
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/ratis/OzoneManagerStateMachine.java
 ##########
 @@ -103,6 +111,16 @@ public void initialize(RaftServer server, RaftGroupId id,
     });
   }
 
+  @Override
+  public SnapshotInfo getLatestSnapshot() {
+    return snapshotInfo;
+  }
+
+  @Override
+  public void notifyIndexUpdate(long term, long index) {
 
 Review comment:
   The supplied index here is the latest log index. We do not want the 
snapshotIndex to be updated to the last log index. It should be the last 
applied index which is persisted to the DB. So we don't update that here.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 298378)
    Time Spent: 2.5h  (was: 2h 20m)

> Load Snapshot info when OM Ratis server starts
> ----------------------------------------------
>
>                 Key: HDDS-1827
>                 URL: https://issues.apache.org/jira/browse/HDDS-1827
>             Project: Hadoop Distributed Data Store
>          Issue Type: Sub-task
>            Reporter: Hanisha Koneru
>            Assignee: Hanisha Koneru
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 2.5h
>  Remaining Estimate: 0h
>
> When Ratis server is starting it looks for the latest snapshot to load it. 
> Even though OM does not save snapshots via Ratis, we need to load the saved 
> snaphsot index into Ratis so that the LogAppender knows to not look for logs 
> before the snapshot index. Otherwise, Ratis will replay the logs from 
> beginning every time it starts up.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to