[
https://issues.apache.org/jira/browse/HDFS-14833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16929918#comment-16929918
]
Jinglun commented on HDFS-14833:
--------------------------------
Thanks [~ayushtkn] for working on this. Patch-002 makes sense to me. Only some
minor comments.
1. Instead of entry could we make it more readable, may be oldEntry,
oldMountTable?
2. In isQuotaUpdated() could we define nsQuota and ssQuota in the if clause.
{code:java}
long nsQuota = -1;
long ssQuota = -1;
-------------------------------
if (mountTable != null) {
...
long nsQuota = preQuota.getQuota();
long ssQuota = preQuota.getSpaceQuota();
...
}{code}
In HDFS-14813 I'm considering adding a Global quota & Remote quota constraint
to make quota management simple. After review I think they are related but no
conflicts.
> RBF: Router Update Doesn't Sync Quota
> -------------------------------------
>
> Key: HDFS-14833
> URL: https://issues.apache.org/jira/browse/HDFS-14833
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Ayush Saxena
> Assignee: Ayush Saxena
> Priority: Major
> Attachments: HDFS-14833-01.patch, HDFS-14833-02.patch
>
>
> HDFS-14777 Added a check to prevent RPC call, It checks whether in the
> present state whether quota is changing.
> But ignores the part that if the locations are changed. if the location is
> changed the new destination should be synchronized with the mount entry
> quota.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
