[
https://issues.apache.org/jira/browse/HDFS-14927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16962309#comment-16962309
]
Leon Gao commented on HDFS-14927:
---------------------------------
[~inigoiri] Thanks for the review
Resolved 1) and 2) in your comments
{quote}Actually why do we do it asynchronously to then wait? Could we just do
the renewLease?
{quote}
I need to keep a renewlease call running in background to have an active thread
in the thread pool, so we can know the metrics work well.
{quote}Will this have timing issues if we rely on the executor to leave the
threads active for a short period? Maybe we should make the parameter that
leaves the thread active to be a long value
{quote}
I was following the similar timing pattern used in other tests in this class.
Some clients calling renewlease in the background and there is a downstream NN
with the slow response of 1~2 seconds to make the async call thread pool busy.
I think it is ok as if this one fails other previous tests should fail as well
:)
> RBF: Add metrics for async callers thread pool
> ----------------------------------------------
>
> Key: HDFS-14927
> URL: https://issues.apache.org/jira/browse/HDFS-14927
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: rbf
> Reporter: Leon Gao
> Assignee: Leon Gao
> Priority: Minor
> Attachments: HDFS-14927.001.patch, HDFS-14927.002.patch,
> HDFS-14927.003.patch, HDFS-14927.004.patch, HDFS-14927.005.patch
>
>
> It is good to add some monitoring on the async caller thread pool to handle
> fan-out RPC client requests, so we know the utilization and when to bump up
> dfs.federation.router.client.thread-size
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
