[ 
https://issues.apache.org/jira/browse/HDFS-14927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16964407#comment-16964407
 ] 

Íñigo Goiri commented on HDFS-14927:
------------------------------------

I don't think you need to catch the exception and then throw it.
Just having the finally should be enough.
The exception will just surface.

> RBF: Add metrics for async callers thread pool
> ----------------------------------------------
>
>                 Key: HDFS-14927
>                 URL: https://issues.apache.org/jira/browse/HDFS-14927
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: rbf
>            Reporter: Leon Gao
>            Assignee: Leon Gao
>            Priority: Minor
>         Attachments: HDFS-14927.001.patch, HDFS-14927.002.patch, 
> HDFS-14927.003.patch, HDFS-14927.004.patch, HDFS-14927.005.patch, 
> HDFS-14927.006.patch, HDFS-14927.007.patch, HDFS-14927.008.patch
>
>
> It is good to add some monitoring on the async caller thread pool to handle 
> fan-out RPC client requests, so we know the utilization and when to bump up 
> dfs.federation.router.client.thread-size



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to