[jira] [Commented] (HDFS-14927) RBF: Add metrics for async callers thread pool

[Jira]

    [ 
https://issues.apache.org/jira/browse/HDFS-14927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16962558#comment-16962558
 ] 

Íñigo Goiri commented on HDFS-14927:
------------------------------------

Thanks for [~LeonG].
A comment, in the waitFor, we shouldn't do asserts, it should be something like:
{code}
    GenericTestUtils.waitFor(() -> {
      Map<String, Integer> newResult = objectMapper.readValue(
          metrics.getAsyncCallerPool(), Map.class);
      if (newResult.get("active") != 1) {
        return false;
      }
     if (newResult.get("max") != 4) {
       return false;
     }
     int total = newResult.get("total");
     if (total >= 1 && total <= 4) {
        return true;
     }
     return false;
    }, 100, 2000);
{code}

> RBF: Add metrics for async callers thread pool
> ----------------------------------------------
>
>                 Key: HDFS-14927
>                 URL: https://issues.apache.org/jira/browse/HDFS-14927
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: rbf
>            Reporter: Leon Gao
>            Assignee: Leon Gao
>            Priority: Minor
>         Attachments: HDFS-14927.001.patch, HDFS-14927.002.patch, 
> HDFS-14927.003.patch, HDFS-14927.004.patch, HDFS-14927.005.patch, 
> HDFS-14927.006.patch
>
>
> It is good to add some monitoring on the async caller thread pool to handle 
> fan-out RPC client requests, so we know the utilization and when to bump up 
> dfs.federation.router.client.thread-size



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org