[ 
https://issues.apache.org/jira/browse/HDFS-14922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16967035#comment-16967035
 ] 

Íñigo Goiri commented on HDFS-14922:
------------------------------------

Places to add the javadoc:
* FSEditLog#logCreateSnapshot().
* CreateSnapshotOp in the definition of mtime as:
{code}
/** Modification time of the edit set by Time.now(). */
long mtime;
{code}
* INodeDirectory#addSnapshot().
* DirectorySnapshottableFeature#addSnapshot(), which should be something 
different to {{now}}.
* SnapshotManager#createSnapshot().

For sure we can add javadocs to all those functions.

> On StartUp , Snapshot modification time got changed
> ---------------------------------------------------
>
>                 Key: HDFS-14922
>                 URL: https://issues.apache.org/jira/browse/HDFS-14922
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: hemanthboyina
>            Assignee: hemanthboyina
>            Priority: Major
>         Attachments: HDFS-14922.001.patch, HDFS-14922.002.patch, 
> HDFS-14922.003.patch
>
>
> Snapshot modification time got changed on namenode restart



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to