[ 
https://issues.apache.org/jira/browse/HDFS-13377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17059064#comment-17059064
 ] 

Íñigo Goiri commented on HDFS-13377:
------------------------------------

This breaks the existing behavior but it seems like a fair use case.
I would expect users to be able to set quotas in their folders.
I think this makes even more sense with groups: I create a folder for my group 
and I want to set quotas for others in the group.
The only problem I see here is that this is an interface that goes through 
DFSAdmin and it makes it a little confusing...
Anyway, this is a big conceptual change and we may want to gather more inputs.

Comments about the patch:
* No need to add the JIRA number to FSNamesystem#466, one can always use git 
blame; there are cases where this makes sense but I don't think this is one of 
those.
* The existing test is pretty good but I would increase the code coverage as 
this is a pretty big change in behavior and I'd like to cover all possible 
corner cases. Possible changes:
** Cover the cases where we check the permissions based on groups (e.g., user2 
is also a member of group hadoop and check if the changes can happen).
** Setting the quota directly as a user without setting as superuser first.
** What about making this its own file and have the cluster in the Before and 
then do each of the tests as a function instead a long method testing a lot of 
things?
* Does {{ugi.doAs}} support lambdas?



BTW, [~hadoop_yangyun], could you format the name of the patches as 
HDFS-13377.003.patch etc?

> The owner of folder can set quota for his sub folder
> ----------------------------------------------------
>
>                 Key: HDFS-13377
>                 URL: https://issues.apache.org/jira/browse/HDFS-13377
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: namenode
>            Reporter: Yang Yun
>            Assignee: Yang Yun
>            Priority: Minor
>         Attachments: HDFS-13377.patch, HDFS-13377.patch, HDFS-13377.patch
>
>
> Currently, only  super user can set quota. That is huge burden for 
> administrator in a large system. Add a new feature to let the owner of a 
> folder also has the privilege to set quota for his sub folders. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to