[
https://issues.apache.org/jira/browse/HDFS-15263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17075874#comment-17075874
]
Íñigo Goiri commented on HDFS-15263:
------------------------------------
Thanks for the patch:
* Can we add javadocs to the methods?
* Can we make the new methods static?
* Is there a more descriptive name for isInScope()? Probably naming the kind of
entity we check.
* Should we be appending PATH_SEPARATOR_STR to the input parameter? This may
change the input parameter which is not expected. The arguments should be final.
* The change in TestClusterTopology#127 shouldn't be there.
* Is there more tests we can add?
> Fix the logic of scope and excluded scope in Network Topology
> -------------------------------------------------------------
>
> Key: HDFS-15263
> URL: https://issues.apache.org/jira/browse/HDFS-15263
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Ayush Saxena
> Assignee: Ayush Saxena
> Priority: Major
> Attachments: HDFS-15263-01.patch, HDFS-15263-02.patch,
> HDFS-15263-03.patch
>
>
> If scope is d1 and excluded scope is d10, still scope will be starting with
> excluded scope, so by current logic it will return null, It should append
> Separator and then check.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
