[
https://issues.apache.org/jira/browse/HDFS-15263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17076617#comment-17076617
]
Íñigo Goiri commented on HDFS-15263:
------------------------------------
* For the appending PATH_SEPARATOR_STR to a new String, yes, something like
that is good.
* For isInScope(), technically it would be isScopeInScope() but is weird, so
let's go with isChildScope().
BTW, in the javadocs, let's be consistent finishing with period the sentences.
> Fix the logic of scope and excluded scope in Network Topology
> -------------------------------------------------------------
>
> Key: HDFS-15263
> URL: https://issues.apache.org/jira/browse/HDFS-15263
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Ayush Saxena
> Assignee: Ayush Saxena
> Priority: Major
> Attachments: HDFS-15263-01.patch, HDFS-15263-02.patch,
> HDFS-15263-03.patch, HDFS-15263-04.patch
>
>
> If scope is d1 and excluded scope is d10, still scope will be starting with
> excluded scope, so by current logic it will return null, It should append
> Separator and then check.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
