[
https://issues.apache.org/jira/browse/HDFS-15263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17075884#comment-17075884
]
Ayush Saxena commented on HDFS-15263:
-------------------------------------
Thanx [~elgoiri] for the review.
bq. Is there a more descriptive name for isInScope()?
The method just checks whether the childScope is contained whether inside the
ParentScope, that is why named "is In Scope", Any suggestions for other name?
bq. Should we be appending PATH_SEPARATOR_STR to the input parameter?
That is the only way I can do the check, Adding PATH_SEPRATOR when it isn't
present won't mislead to another node. But if I don't add, May scope is rack1
and other is rack10, rack10 startsWith rack1 will be true, but rack1 isn't
contained inside rack1. this is the test also that I added
> Fix the logic of scope and excluded scope in Network Topology
> -------------------------------------------------------------
>
> Key: HDFS-15263
> URL: https://issues.apache.org/jira/browse/HDFS-15263
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Ayush Saxena
> Assignee: Ayush Saxena
> Priority: Major
> Attachments: HDFS-15263-01.patch, HDFS-15263-02.patch,
> HDFS-15263-03.patch, HDFS-15263-04.patch
>
>
> If scope is d1 and excluded scope is d10, still scope will be starting with
> excluded scope, so by current logic it will return null, It should append
> Separator and then check.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
