[ 
https://issues.apache.org/jira/browse/HDFS-2664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13167909#comment-13167909
 ] 

Doug Cutting commented on HDFS-2664:
------------------------------------

I don't think we should remove the test without removing the code that it tests.

What I meant that you might propose is to remove Avro RPC altogether from 
common and HDFS.  The Avro RPC implementation and this test primarily currently 
serve to keep the RpcEngine AP a pluggable interface, facilitating future 
alternate RPC engines.  If folks don't think RpcEngine pluggability is valuable 
then perhaps we should remove AvroRpcEngine, this test, and even the RpcEngine 
API itself.
                
> Remove TestDFSOverAvroRpc
> -------------------------
>
>                 Key: HDFS-2664
>                 URL: https://issues.apache.org/jira/browse/HDFS-2664
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Suresh Srinivas
>            Assignee: Suresh Srinivas
>             Fix For: 0.24.0
>
>
> With HDFS-2647, HDFS has transitioned to protocol buffers. The server side 
> implementation registers <Protocol>PB.class and a BlockingService as 
> implementation. Client side uses <Protocol>PB.class as the interface. The RPC 
> engine used is protobuf both for the RPC proxy and the server. With this 
> TestDFSOverAvroRpc fails. I propose removing this test.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to