[
https://issues.apache.org/jira/browse/HDFS-2664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13168625#comment-13168625
]
Suresh Srinivas commented on HDFS-2664:
---------------------------------------
Currently there is a lot of work that was done to cleanup pluggability of RPC
engines. So I do not think any thing is broken in terms of pluggability of RPC
engines. The issue is merely with the test, which expects to work by just
changing the RPC engine for a protocol, without regard to how RPC
implementation is done.
The way AvroRpc tests are implemented currently, it depends on just replacing
the RPC engine to AvroRpcEngine. This worked in the past only because, both
writable and Avro use reflection to invoke server implementation. That is no
longer the case with protobuf.
I see couple of choices:
1. Instead of using HDFS for testing the pluggability, which has resulted in
TestDfsOverAvroRpc being broken several times, I suggest writing a test in
common, along the lines of TestProtoBufRpc. There are several writable rpc
tests as well, along similar lines. This will help in not having to fix
TestDfsOverAvroRpc as HDFS changes.
2. Change TestDfsOverAvroRpc to supply Writable based implementation of
Namenode RPCs. This will fix the test. However my vote is to do the option 1.
> Remove TestDFSOverAvroRpc
> -------------------------
>
> Key: HDFS-2664
> URL: https://issues.apache.org/jira/browse/HDFS-2664
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: 0.24.0
>
>
> With HDFS-2647, HDFS has transitioned to protocol buffers. The server side
> implementation registers <Protocol>PB.class and a BlockingService as
> implementation. Client side uses <Protocol>PB.class as the interface. The RPC
> engine used is protobuf both for the RPC proxy and the server. With this
> TestDFSOverAvroRpc fails. I propose removing this test.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
