[ 
https://issues.apache.org/jira/browse/HDFS-2664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13168811#comment-13168811
 ] 

Doug Cutting commented on HDFS-2664:
------------------------------------

I believe that HDFS-2647 is the best place for this discussion.  That patch 
caused this test to fail.  That issue should be reverted and re-committed when 
it can pass tests before it is committed.  That's the normal practice.  If you 
wish to change the contract for RPCEngine, if you wish to remove AvroRpcEngine, 
or however you wish to address it, it should be addressed before you commit 
rather than by committing a patch that causes existing tests to fail.  If 
AvroRPCEngine is no longer of interest, remove it in a separate issue, 
otherwise maintain it so that its tests continue to pass.  Please do not just 
remove the failing tests alone.
                
> Remove TestDFSOverAvroRpc
> -------------------------
>
>                 Key: HDFS-2664
>                 URL: https://issues.apache.org/jira/browse/HDFS-2664
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Suresh Srinivas
>            Assignee: Suresh Srinivas
>             Fix For: 0.24.0
>
>
> With HDFS-2647, HDFS has transitioned to protocol buffers. The server side 
> implementation registers <Protocol>PB.class and a BlockingService as 
> implementation. Client side uses <Protocol>PB.class as the interface. The RPC 
> engine used is protobuf both for the RPC proxy and the server. With this 
> TestDFSOverAvroRpc fails. I propose removing this test.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to