[
https://issues.apache.org/jira/browse/HDFS-15025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17202364#comment-17202364
]
Ayush Saxena commented on HDFS-15025:
-------------------------------------
This breaks {{TestRouterQuota#testStorageTypeQuota}}
https://ci-hadoop.apache.org/job/PreCommit-HDFS-Build/204/testReport/org.apache.hadoop.hdfs.server.federation.router/TestRouterQuota/testStorageTypeQuota/
{code:java}
- RAM_DISK(true),
- SSD(false),
- DISK(false),
- ARCHIVE(false),
- PROVIDED(false);
+ RAM_DISK(true, true),
+ NVDIMM(false, true),
{code}
I didn't give a check to the code, But I have a question, Why is {{NVDIMM}}
added in between rather than being in the end?
This changes the {{ordinal}} of the enums, Potentially can break others code as
well, If there is no very specific reason. Please consider moving it to the
end. I couldn't spare time to check if putting it between would be an
incompatible change or not.
Anyway, I have created HDFS-15600 for the test. I would leave deciding on the
position of the storage type for the folks involved here.
> Applying NVDIMM storage media to HDFS
> -------------------------------------
>
> Key: HDFS-15025
> URL: https://issues.apache.org/jira/browse/HDFS-15025
> Project: Hadoop HDFS
> Issue Type: New Feature
> Components: datanode, hdfs
> Reporter: YaYun Wang
> Assignee: YaYun Wang
> Priority: Major
> Labels: pull-request-available
> Fix For: 3.4.0
>
> Attachments: Applying NVDIMM to HDFS.pdf, HDFS-15025.001.patch,
> HDFS-15025.002.patch, HDFS-15025.003.patch, HDFS-15025.004.patch,
> HDFS-15025.005.patch, HDFS-15025.006.patch, NVDIMM_patch(WIP).patch
>
> Time Spent: 12h 10m
> Remaining Estimate: 0h
>
> The non-volatile memory NVDIMM is faster than SSD, it can be used
> simultaneously with RAM, DISK, SSD. The data of HDFS stored directly on
> NVDIMM can not only improves the response rate of HDFS, but also ensure the
> reliability of the data.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
