[ 
https://issues.apache.org/jira/browse/HDFS-15025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17202528#comment-17202528
 ] 

Ayush Saxena commented on HDFS-15025:
-------------------------------------

Thanx [~liuml07] for the pointers, I indeed didn't check the comment above and 
the interface stability.
But will it create an issue with upgrade, Since the {{FsImage}} write and reads 
the ordinal of storage type?

{code:java}
    @Override
    public
    void writeFields(DataOutputStream out) throws IOException {
      FSImageSerialization.writeString(src, out);
      FSImageSerialization.writeInt(type.ordinal(), out);
      FSImageSerialization.writeLong(dsQuota, out);
    }

    @Override
    void readFields(DataInputStream in, int logVersion)
      throws IOException {
      this.src = FSImageSerialization.readString(in);
      this.type = 
StorageType.parseStorageType(FSImageSerialization.readInt(in));
      this.dsQuota = FSImageSerialization.readLong(in);
    }
{code}

Just give a check to that as well in {{FsEditLogOp#SetQuotaByStorageTypeOp}}, 
If everything is good over there as well, we can just fix the test

cc. [~vinayakumarb]


> Applying NVDIMM storage media to HDFS
> -------------------------------------
>
>                 Key: HDFS-15025
>                 URL: https://issues.apache.org/jira/browse/HDFS-15025
>             Project: Hadoop HDFS
>          Issue Type: New Feature
>          Components: datanode, hdfs
>            Reporter: YaYun Wang
>            Assignee: YaYun Wang
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 3.4.0
>
>         Attachments: Applying NVDIMM to HDFS.pdf, HDFS-15025.001.patch, 
> HDFS-15025.002.patch, HDFS-15025.003.patch, HDFS-15025.004.patch, 
> HDFS-15025.005.patch, HDFS-15025.006.patch, NVDIMM_patch(WIP).patch
>
>          Time Spent: 12h 10m
>  Remaining Estimate: 0h
>
> The non-volatile memory NVDIMM is faster than SSD, it can be used 
> simultaneously with RAM, DISK, SSD. The data of HDFS stored directly on 
> NVDIMM can not only improves the response rate of HDFS, but also ensure the 
> reliability of the data.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to