[ 
https://issues.apache.org/jira/browse/HDFS-15767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17269492#comment-17269492
 ] 

Ayush Saxena commented on HDFS-15767:
-------------------------------------

Thanx [~LiJinglun] for the update. There is a test failure due to change in 
config, apart from that I don't have any comments. once fixed should be good 
enough.

Just a point to mention :

This can mess up if the call from client fails in between, since here we aren't 
doing a proxy to Namenode, the RetryCache won't pitch in to identify a 
duplicate call from a client. So, we might see some issues here and there, (Not 
sure we can be lucky)We can keep a Jira open for that to investigate later the 
call fail scenarios here. and as a note the client call timeout should be high 
enough so that the job gets completed before the client terminates probably a 
thing to mention in the docs as well.

We can mention about this in the Release Notes too and follow up with the 
failure cases.

One more thing since you have to fix the test, can you add the interface 
stability as unstable and audience too for \{{RouterFederationRename}}

> RBF: Router federation rename of directory.
> -------------------------------------------
>
>                 Key: HDFS-15767
>                 URL: https://issues.apache.org/jira/browse/HDFS-15767
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Jinglun
>            Assignee: Jinglun
>            Priority: Major
>         Attachments: HDFS-15767.001.patch, HDFS-15767.002.patch, 
> HDFS-15767.003.patch, HDFS-15767.004.patch, HDFS-15767.005.patch
>
>
> This Jira trys to support rename of directory across namespaces using 
> fedbalance framework. 
> We can do the router federation rename when:
>  # Both the src and dst has only one remote location.
>  # The src and dst remote locations are at different namespaces.
>  # The src is a directory.(Fedbalance depends on snapshot).
>  # The dst doesn't exist.
> We can implement router federation rename of file in a new task so the patch 
> won't be too big to review.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to