[
https://issues.apache.org/jira/browse/HDFS-16638?focusedWorklogId=784237&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-784237
]
ASF GitHub Bot logged work on HDFS-16638:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Jun/22 14:09
Start Date: 23/Jun/22 14:09
Worklog Time Spent: 10m
Work Description: cxzl25 commented on PR #4480:
URL: https://github.com/apache/hadoop/pull/4480#issuecomment-1164455182
> Thanks @cxzl25 for your patch. I have a question about it and looking
forward your feedback. Can this change improve the namenode performance? I see
that some places specially remove this judgment, and use log.info("{}", XXX)
replace it.
>
> Or can you do some performance test for it? use this judgment or not.
We have some JIRAs that use the `isDebugEnabled` judgment.
At the beginning, I found that the log of `Removing stale replica` has
meaningless string splicing, and using `NameNode.blockStateChangeLog` can be
replaced by `blockLog`, because this debug-level log is called a lot every day.
So I fixed the other problems by the way.
Issue Time Tracking
-------------------
Worklog Id: (was: 784237)
Time Spent: 0.5h (was: 20m)
> Add isDebugEnabled check for debug blockLogs in BlockManager
> ------------------------------------------------------------
>
> Key: HDFS-16638
> URL: https://issues.apache.org/jira/browse/HDFS-16638
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: namenode
> Reporter: dzcxzl
> Priority: Trivial
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> There are lots of concatenating Strings using blockLog.debug in BlockManager.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
