[ 
https://issues.apache.org/jira/browse/HDFS-16638?focusedWorklogId=787407&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-787407
 ]

ASF GitHub Bot logged work on HDFS-16638:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 03/Jul/22 15:32
            Start Date: 03/Jul/22 15:32
    Worklog Time Spent: 10m 
      Work Description: virajjasani commented on PR #4480:
URL: https://github.com/apache/hadoop/pull/4480#issuecomment-1173114547

   I think it's fine moving forward because in the presence of this patch, the 
worst case scenario would be calculating if DEBUG level is enabled twice, which 
is nothing compared to even static String concat. Hence, no objections from my 
side. Thanks @cxzl25 for the work!




Issue Time Tracking
-------------------

    Worklog Id:     (was: 787407)
    Time Spent: 2h 10m  (was: 2h)

> Add isDebugEnabled check for debug blockLogs in BlockManager
> ------------------------------------------------------------
>
>                 Key: HDFS-16638
>                 URL: https://issues.apache.org/jira/browse/HDFS-16638
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: namenode
>            Reporter: dzcxzl
>            Priority: Trivial
>              Labels: pull-request-available
>          Time Spent: 2h 10m
>  Remaining Estimate: 0h
>
> There are lots of concatenating Strings using blockLog.debug in BlockManager.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to