[
https://issues.apache.org/jira/browse/HDFS-16638?focusedWorklogId=784917&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-784917
]
ASF GitHub Bot logged work on HDFS-16638:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Jun/22 03:06
Start Date: 27/Jun/22 03:06
Worklog Time Spent: 10m
Work Description: ZanderXu commented on PR #4480:
URL: https://github.com/apache/hadoop/pull/4480#issuecomment-1166783802
Thanks @virajjasani.
```
blockLog.debug("BLOCK* invalidateBlocks: postponing " +
"invalidation of {} on {} because {} replica(s) are located on "
+
"nodes with potentially out-of-date block reports", b, dn,
nr.replicasOnStaleNodes());
```
Like this debug log, in order to satisfy the checkStyle, we must split the
log into multiple lines. So even we use parameterized args `{}`, there is still
string concatenation.
Like this debug log, do you have some good ideas?
Issue Time Tracking
-------------------
Worklog Id: (was: 784917)
Time Spent: 1h 10m (was: 1h)
> Add isDebugEnabled check for debug blockLogs in BlockManager
> ------------------------------------------------------------
>
> Key: HDFS-16638
> URL: https://issues.apache.org/jira/browse/HDFS-16638
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: namenode
> Reporter: dzcxzl
> Priority: Trivial
> Labels: pull-request-available
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> There are lots of concatenating Strings using blockLog.debug in BlockManager.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
