[
https://issues.apache.org/jira/browse/HDFS-16892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17683760#comment-17683760
]
ASF GitHub Bot commented on HDFS-16892:
---------------------------------------
haiyang1987 commented on code in PR #5301:
URL: https://github.com/apache/hadoop/pull/5301#discussion_r1095503796
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java:
##########
@@ -901,7 +901,7 @@ public Builder setNumHandlers(int numHandlers) {
* @return Default: -1.
* @param numReaders input numReaders.
*/
- public Builder setnumReaders(int numReaders) {
+ public Builder setNumReaders(int numReaders) {
Review Comment:
Hi @tomscut @steveloughran @ayushtkn thanks help review it.
sorry for the late reply.
Considering that it is a public method in a public class and avoid
compilation failures in downstream use, can create a new method as
@steveloughran said, and keep the old method as deprecated, which may be
better.
I will update PR later.
> Fix method name of RPC.Builder#setnumReaders
> ---------------------------------------------
>
> Key: HDFS-16892
> URL: https://issues.apache.org/jira/browse/HDFS-16892
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Haiyang Hu
> Assignee: Haiyang Hu
> Priority: Minor
> Labels: pull-request-available
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
