[
https://issues.apache.org/jira/browse/HDFS-16892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17684859#comment-17684859
]
ASF GitHub Bot commented on HDFS-16892:
---------------------------------------
steveloughran commented on code in PR #5301:
URL: https://github.com/apache/hadoop/pull/5301#discussion_r1097763234
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java:
##########
@@ -896,15 +896,26 @@ public Builder setNumHandlers(int numHandlers) {
this.numHandlers = numHandlers;
return this;
}
-
- /**
+
+ /**@deprecated call {@link #setNumReaders(int value)} instead.
Review Comment:
can you put that on the line below.
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java:
##########
@@ -896,15 +896,26 @@ public Builder setNumHandlers(int numHandlers) {
this.numHandlers = numHandlers;
return this;
}
-
- /**
+
+ /**@deprecated call {@link #setNumReaders(int value)} instead.
+ *
* @return Default: -1.
* @param numReaders input numReaders.
*/
- public Builder setNumReaders(int numReaders) {
+ @Deprecated
+ public Builder setnumReaders(int numReaders) {
this.numReaders = numReaders;
return this;
}
+
+ /**
+ * @return Default: -1.
Review Comment:
1. add "set the number of reader threads"
2. return value is "this builder"
> Fix method name of RPC.Builder#setnumReaders
> ---------------------------------------------
>
> Key: HDFS-16892
> URL: https://issues.apache.org/jira/browse/HDFS-16892
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Haiyang Hu
> Assignee: Haiyang Hu
> Priority: Minor
> Labels: pull-request-available
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
