[
https://issues.apache.org/jira/browse/HDFS-17312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17801486#comment-17801486
]
ASF GitHub Bot commented on HDFS-17312:
---------------------------------------
ashutoshcipher commented on code in PR #6394:
URL: https://github.com/apache/hadoop/pull/6394#discussion_r1438938088
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockReceiver.java:
##########
@@ -598,7 +599,9 @@ private int receivePacket() throws IOException {
return 0;
}
- datanode.metrics.incrPacketsReceived();
Review Comment:
I see you've updated it to increment packetsReceived only when seqno is not
HEART_BEAT_SEQNO. This is a critical change for accurately tracking packets.
However, it would be helpful to add a comment here explaining why heartbeats
are excluded from this metric for clarity and future reference.
> packetsReceived metric should ignore heartbeat packet
> -----------------------------------------------------
>
> Key: HDFS-17312
> URL: https://issues.apache.org/jira/browse/HDFS-17312
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: datanode
> Affects Versions: 3.3.6
> Reporter: farmmamba
> Assignee: farmmamba
> Priority: Major
> Labels: pull-request-available
>
> Metric packetsReceived should ignore heartbeat packet and only used to count
> data packets and last packet in block.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
