[
https://issues.apache.org/jira/browse/HDFS-17312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17801492#comment-17801492
]
ASF GitHub Bot commented on HDFS-17312:
---------------------------------------
hfutatzhanghb commented on PR #6394:
URL: https://github.com/apache/hadoop/pull/6394#issuecomment-1873097496
> Can you check if there any other parts of the system that might rely on
the current behavior of the packetsReceived metric including heartbeat packets?
We need to ensure this change doesn't inadvertently affect other
functionalities.
>
> Testing and Validation: Can you confirm if there are existing tests that
cover this change or if new tests are needed? It's essential to validate that
this modification behaves as expected in various scenarios, including edge
cases.
Hi, @ashutoshcipher. Sir. I have checked other parts which using
packetsReceived metrics. There are no parts or functionalities rely on the
current behavior of the packetsReceived metric including heartbeat packets. We
use find in path to search packetsReceived in all hadoop codes.
> packetsReceived metric should ignore heartbeat packet
> -----------------------------------------------------
>
> Key: HDFS-17312
> URL: https://issues.apache.org/jira/browse/HDFS-17312
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: datanode
> Affects Versions: 3.3.6
> Reporter: farmmamba
> Assignee: farmmamba
> Priority: Major
> Labels: pull-request-available
>
> Metric packetsReceived should ignore heartbeat packet and only used to count
> data packets and last packet in block.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
