[
https://issues.apache.org/jira/browse/HDFS-17312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17801493#comment-17801493
]
ASF GitHub Bot commented on HDFS-17312:
---------------------------------------
hfutatzhanghb commented on code in PR #6394:
URL: https://github.com/apache/hadoop/pull/6394#discussion_r1438949141
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockReceiver.java:
##########
@@ -598,7 +599,9 @@ private int receivePacket() throws IOException {
return 0;
}
- datanode.metrics.incrPacketsReceived();
Review Comment:
@ashutoshcipher Sir, thanks for your advise. The documentation of
packetsReceived metric is showed as below:
<img width="1214" alt="image"
src="https://github.com/apache/hadoop/assets/25115709/30c8797f-ce98-40d3-8c92-968b7b2c4ada";>
Its original goal is counting total packets received by DataNode excluding
heartbeat packet from client.
> packetsReceived metric should ignore heartbeat packet
> -----------------------------------------------------
>
> Key: HDFS-17312
> URL: https://issues.apache.org/jira/browse/HDFS-17312
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: datanode
> Affects Versions: 3.3.6
> Reporter: farmmamba
> Assignee: farmmamba
> Priority: Major
> Labels: pull-request-available
>
> Metric packetsReceived should ignore heartbeat packet and only used to count
> data packets and last packet in block.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
