[
https://issues.apache.org/jira/browse/HDFS-12431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18011324#comment-18011324
]
ASF GitHub Bot commented on HDFS-12431:
---------------------------------------
slfan1989 commented on code in PR #7841:
URL: https://github.com/apache/hadoop/pull/7841#discussion_r2246635377
##########
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/BlockReportTestBase.java:
##########
@@ -910,7 +927,7 @@ public void run() {
startDNandWait(filePath, true);
} catch (Exception e) {
e.printStackTrace();
- Assert.fail("Failed to start BlockChecker: " + e);
+ Assertions.fail("Failed to start BlockChecker: " + e);
Review Comment:
Assertions. It would be best if they could be extracted to imports.
##########
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/InternalDataNodeTestUtils.java:
##########
@@ -172,8 +172,8 @@ public DatanodeRegistration answer(InvocationOnMock
invocation)
@Override
DatanodeProtocolClientSideTranslatorPB connectToNN(
InetSocketAddress nnAddr) throws IOException {
- Assert.assertEquals(nnSocketAddr, nnAddr);
- return namenode;
+ Assertions.assertEquals(nnSocketAddr, nnAddr);
Review Comment:
Assertions. It would be best if they could be extracted to imports.
> Upgrade JUnit from 4 to 5 in hadoop-hdfs hdfs
> -----------------------------------------------
>
> Key: HDFS-12431
> URL: https://issues.apache.org/jira/browse/HDFS-12431
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: test
> Reporter: Ajay Kumar
> Assignee: Hualong Zhang
> Priority: Major
> Labels: pull-request-available
> Fix For: 3.5.0
>
>
> Upgrade JUnit from 4 to 5 in hadoop-hdfs hdfs (i.e org.apache.hadoop.hdfs)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
