[ https://issues.apache.org/jira/browse/HDFS-12431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18011336#comment-18011336 ]
ASF GitHub Bot commented on HDFS-12431: --------------------------------------- zhtttylz commented on code in PR #7841: URL: https://github.com/apache/hadoop/pull/7841#discussion_r2246768594 ########## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/InternalDataNodeTestUtils.java: ########## @@ -172,8 +172,8 @@ public DatanodeRegistration answer(InvocationOnMock invocation) @Override DatanodeProtocolClientSideTranslatorPB connectToNN( InetSocketAddress nnAddr) throws IOException { - Assert.assertEquals(nnSocketAddr, nnAddr); - return namenode; + Assertions.assertEquals(nnSocketAddr, nnAddr); Review Comment: Thanks a lot for your review—I'll update the code right away! > Upgrade JUnit from 4 to 5 in hadoop-hdfs hdfs > ----------------------------------------------- > > Key: HDFS-12431 > URL: https://issues.apache.org/jira/browse/HDFS-12431 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: test > Reporter: Ajay Kumar > Assignee: Hualong Zhang > Priority: Major > Labels: pull-request-available > Fix For: 3.5.0 > > > Upgrade JUnit from 4 to 5 in hadoop-hdfs hdfs (i.e org.apache.hadoop.hdfs) -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org