[ 
https://issues.apache.org/jira/browse/HDFS-2998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13241967#comment-13241967
 ] 

Colin Patrick McCabe commented on HDFS-2998:
--------------------------------------------

I don't really think we should make this public.  It's tied pretty tightly to 
the on-disk image format, which we might want to change in the future.  Should 
non-HDFS packages really be peeking at how HDFS stores metadata on disk?  Let's 
come up with better interfaces than this if we need them, but not expose our 
guts for the world to see.
                
> OfflineImageViewer and ImageVisitor should be annotated public
> --------------------------------------------------------------
>
>                 Key: HDFS-2998
>                 URL: https://issues.apache.org/jira/browse/HDFS-2998
>             Project: Hadoop HDFS
>          Issue Type: New Feature
>    Affects Versions: 0.23.1
>            Reporter: Aaron T. Myers
>
> The OfflineImageViewer is currently annotated as InterfaceAudience.Private. 
> It's intended for subclassing, so it should be annotated as the public API 
> that it is.
> The ImageVisitor class should similarly be annotated public (evolving is 
> fine). Note that it should also be changed to be public; it's currently 
> package-private, which means that users have to cheat with their subclass 
> package name.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to