[
https://issues.apache.org/jira/browse/HDFS-2998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13247040#comment-13247040
]
Suresh Srinivas commented on HDFS-2998:
---------------------------------------
I am not sure why these classes should be public. Backward compatibility is not
what makes some thing public. It is also the intent to open it up for external
developers. I do not believe these classes need to be.
Also we need to address the previous comment:
bq. We could consider it making public. We should make all the other classes
not marked public, but are referenced by OIV public also.
> OfflineImageViewer and ImageVisitor should be annotated public
> --------------------------------------------------------------
>
> Key: HDFS-2998
> URL: https://issues.apache.org/jira/browse/HDFS-2998
> Project: Hadoop HDFS
> Issue Type: New Feature
> Affects Versions: 0.23.1
> Reporter: Aaron T. Myers
>
> The OfflineImageViewer is currently annotated as InterfaceAudience.Private.
> It's intended for subclassing, so it should be annotated as the public API
> that it is.
> The ImageVisitor class should similarly be annotated public (evolving is
> fine). Note that it should also be changed to be public; it's currently
> package-private, which means that users have to cheat with their subclass
> package name.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
