[
https://issues.apache.org/jira/browse/HDFS-2998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13241977#comment-13241977
]
Colin Patrick McCabe commented on HDFS-2998:
--------------------------------------------
Ok, I've looked at a little more of the context here, and I now agree that we
should annotate these as public.
It looks like the API that OfflineImageViewer presents to the world is one that
doesn't have a direct dependency on how the image is stored on-disk. So we
will be able to change things in the future, as long as we have some backwards
compatibility story here. Sorry for the noise, just was concerned about
compatibility for a moment there.
> OfflineImageViewer and ImageVisitor should be annotated public
> --------------------------------------------------------------
>
> Key: HDFS-2998
> URL: https://issues.apache.org/jira/browse/HDFS-2998
> Project: Hadoop HDFS
> Issue Type: New Feature
> Affects Versions: 0.23.1
> Reporter: Aaron T. Myers
>
> The OfflineImageViewer is currently annotated as InterfaceAudience.Private.
> It's intended for subclassing, so it should be annotated as the public API
> that it is.
> The ImageVisitor class should similarly be annotated public (evolving is
> fine). Note that it should also be changed to be public; it's currently
> package-private, which means that users have to cheat with their subclass
> package name.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
