[
https://issues.apache.org/jira/browse/HDFS-3627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13605588#comment-13605588
]
Daryn Sharp commented on HDFS-3627:
-----------------------------------
Good question. It's probably not an issue. If you have access to the image to
run the offline tool, then you have the means to get the bytes of the secret
key anyway...
I do question the need to touch the {{DelegationKey}} class. I think the patch
can be confined to just the offline tool:
# While hashCode and equals seems reasonable, I have learned the hard way that
innocuous changes can have unintended consequences. I wouldn't be surprised if
something somewhere is relying on keys to always appear un-equivalent. I'd
recommend being "better safe than sorry".
# I'm not sure we should be adding ctors and methods to the delegation key to
support the presentation format chosen for the offline tool. I'd prefer that
the tool format the key in base64 itself.
> OfflineImageViewer oiv Indented processor prints out the Java class name in
> the DELEGATION_KEY field
> ----------------------------------------------------------------------------------------------------
>
> Key: HDFS-3627
> URL: https://issues.apache.org/jira/browse/HDFS-3627
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 0.23.0
> Reporter: Ravi Prakash
> Priority: Minor
> Attachments: HDFS-3627.patch, HDFS-3627.patch, HDFS-3627.patch,
> HDFS-3627.patch
>
>
> Instead of the contents of the delegation key this is printed out
> DELEGATION_KEY =
> org.apache.hadoop.security.token.delegation.DelegationKey@1e2ca7
> DELEGATION_KEY =
> org.apache.hadoop.security.token.delegation.DelegationKey@105bd58
> DELEGATION_KEY =
> org.apache.hadoop.security.token.delegation.DelegationKey@1d1e730
> DELEGATION_KEY =
> org.apache.hadoop.security.token.delegation.DelegationKey@1a116c9
> DELEGATION_KEY =
> org.apache.hadoop.security.token.delegation.DelegationKey@df1832
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
