[ 
https://issues.apache.org/jira/browse/HDFS-3627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13608933#comment-13608933
 ] 

Daryn Sharp commented on HDFS-3627:
-----------------------------------

bq. Also, while the OEV tool does have a binary processor to create the edits 
file from an XML textual dump, the OIV tool does not, so for my understanding, 
no other changes are required.

A few issues/questions:
# Most important: It appears this patch may break the ability for the OIV to 
convert from xml back to a binary image?
# For consistency, I think the other human-readable OIV output formats should 
similarly decode a delegation key.  It looks like {{IndentedImageVisitor}} may 
be the only one.
# It'd be nice for the OEV to also decode the delegation key instead of 
printing the class name.  This appears to require a similar change in 
{{FSEditLogOp.UpdateMasterKeyOp.toXml/fromXml}}.

As an aside, I'm somewhat surprised the xml encode/decode isn't common between 
OIV/OEV, but I'm not suggesting any changes there.


                
> OfflineImageViewer oiv Indented processor prints out the Java class name in 
> the DELEGATION_KEY field
> ----------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-3627
>                 URL: https://issues.apache.org/jira/browse/HDFS-3627
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 0.23.0
>            Reporter: Ravi Prakash
>            Priority: Minor
>         Attachments: HDFS-3627.patch, HDFS-3627.patch, HDFS-3627.patch, 
> HDFS-3627.patch, HDFS-3627.patch
>
>
> Instead of the contents of the delegation key this is printed out
> DELEGATION_KEY = 
> org.apache.hadoop.security.token.delegation.DelegationKey@1e2ca7
>     DELEGATION_KEY = 
> org.apache.hadoop.security.token.delegation.DelegationKey@105bd58
>     DELEGATION_KEY = 
> org.apache.hadoop.security.token.delegation.DelegationKey@1d1e730
>     DELEGATION_KEY = 
> org.apache.hadoop.security.token.delegation.DelegationKey@1a116c9
>     DELEGATION_KEY = 
> org.apache.hadoop.security.token.delegation.DelegationKey@df1832

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to