[
https://issues.apache.org/jira/browse/HDFS-3627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13606309#comment-13606309
]
Daryn Sharp commented on HDFS-3627:
-----------------------------------
The original patch looks good. The added tests will test the new, and arguably
unnecessary, changes to {{DelegationKey}} as opposed to the real changes to the
offline tool. I think there are tests for the output of the offline image
tool. If so, you'd have to enable security will cause a master key roll and
allow you to test the output.
Do you also need changes to allow the offline tools to read the new textual
dump? I think they are supposed to be able convert from binary to text and
vice versa.
> OfflineImageViewer oiv Indented processor prints out the Java class name in
> the DELEGATION_KEY field
> ----------------------------------------------------------------------------------------------------
>
> Key: HDFS-3627
> URL: https://issues.apache.org/jira/browse/HDFS-3627
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 0.23.0
> Reporter: Ravi Prakash
> Priority: Minor
> Attachments: HDFS-3627.patch, HDFS-3627.patch, HDFS-3627.patch,
> HDFS-3627.patch
>
>
> Instead of the contents of the delegation key this is printed out
> DELEGATION_KEY =
> org.apache.hadoop.security.token.delegation.DelegationKey@1e2ca7
> DELEGATION_KEY =
> org.apache.hadoop.security.token.delegation.DelegationKey@105bd58
> DELEGATION_KEY =
> org.apache.hadoop.security.token.delegation.DelegationKey@1d1e730
> DELEGATION_KEY =
> org.apache.hadoop.security.token.delegation.DelegationKey@1a116c9
> DELEGATION_KEY =
> org.apache.hadoop.security.token.delegation.DelegationKey@df1832
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
