[
https://issues.apache.org/jira/browse/HDFS-4705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13635778#comment-13635778
]
Chris Nauroth commented on HDFS-4705:
-------------------------------------
I can see 2 different approaches to fixing these tests:
# Fix each individual test to initialize dfs.namenode.name.dir properly.
# Add special case logic in {{Configuration#substituteVars}} saying that if the
value starts with "file:", then pass any substitution values through
{{File#toURI}} and {{URI#getPath}}. On Windows, this would have the effect of
converting '\' to '/' and yield a valid URI.
My initial patch takes the first approach. I expect I can quickly prep a patch
for the second approach too so we can compare and contrast.
BTW, I apologize if I stepped on your toes here. Somehow, I missed that you
had already filed this jira.
> TestAllowFormat fails on Windows because of invalid dfs.namenode.name.dir
> -------------------------------------------------------------------------
>
> Key: HDFS-4705
> URL: https://issues.apache.org/jira/browse/HDFS-4705
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 3.0.0
> Reporter: Ivan Mitic
> Assignee: Ivan Mitic
> Priority: Minor
> Attachments: HDFS-4705.1.patch
>
>
> Test fails on Windows with the below exception:
> {code}
> testFormatShouldBeIgnoredForNonFileBasedDirs(org.apache.hadoop.hdfs.server.namenode.TestAllowFormat)
> Time elapsed: 49 sec <<< ERROR!
> java.io.IOException: No image directories available!
> at
> org.apache.hadoop.hdfs.server.namenode.FSImage.saveFSImageInAllDirs(FSImage.java:912)
> at
> org.apache.hadoop.hdfs.server.namenode.FSImage.saveFSImageInAllDirs(FSImage.java:905)
> at
> org.apache.hadoop.hdfs.server.namenode.FSImage.format(FSImage.java:151)
> at
> org.apache.hadoop.hdfs.server.namenode.NameNode.format(NameNode.java:758)
> at
> org.apache.hadoop.hdfs.server.namenode.NameNode.format(NameNode.java:259)
> at
> org.apache.hadoop.hdfs.server.namenode.TestAllowFormat.testFormatShouldBeIgnoredForNonFileBasedDirs(TestAllowFormat.java:181)
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
