[
https://issues.apache.org/jira/browse/HDFS-4705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13635857#comment-13635857
]
Ivan Mitic commented on HDFS-4705:
----------------------------------
Hey Chris, no worries at all, and thanks for attaching the patch!
I started with a similar approach to yours and then saw the other test
failures, so I thought it is worth to spent some time seeing if it makes sense
to fix them all at ones.
I was thinking along the lines of changing {{Util#fileAsURI}} such that it
converts the given File to Path and then from Path to the URI. However, on top
of this we'd also have to change the default value for
{{dfs.namenode.name.dir}} as "file://$hadoop.tmp.dir/dfs/name" is actually not
a valid local URI (there should 3 forward slashes after "file:", IOW:
"file:///$hadoop.tmp.dir/dfs/name"). I haven't tested this out, so it might be
that there are some problems here.
You're welcome to take this up if you want :)
> TestAllowFormat fails on Windows because of invalid dfs.namenode.name.dir
> -------------------------------------------------------------------------
>
> Key: HDFS-4705
> URL: https://issues.apache.org/jira/browse/HDFS-4705
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 3.0.0
> Reporter: Ivan Mitic
> Assignee: Ivan Mitic
> Priority: Minor
> Attachments: HDFS-4705.1.patch
>
>
> Test fails on Windows with the below exception:
> {code}
> testFormatShouldBeIgnoredForNonFileBasedDirs(org.apache.hadoop.hdfs.server.namenode.TestAllowFormat)
> Time elapsed: 49 sec <<< ERROR!
> java.io.IOException: No image directories available!
> at
> org.apache.hadoop.hdfs.server.namenode.FSImage.saveFSImageInAllDirs(FSImage.java:912)
> at
> org.apache.hadoop.hdfs.server.namenode.FSImage.saveFSImageInAllDirs(FSImage.java:905)
> at
> org.apache.hadoop.hdfs.server.namenode.FSImage.format(FSImage.java:151)
> at
> org.apache.hadoop.hdfs.server.namenode.NameNode.format(NameNode.java:758)
> at
> org.apache.hadoop.hdfs.server.namenode.NameNode.format(NameNode.java:259)
> at
> org.apache.hadoop.hdfs.server.namenode.TestAllowFormat.testFormatShouldBeIgnoredForNonFileBasedDirs(TestAllowFormat.java:181)
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
