[ 
https://issues.apache.org/jira/browse/HDFS-5224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13788371#comment-13788371
 ] 

Andrew Wang commented on HDFS-5224:
-----------------------------------

Hey Chris, thanks for picking this up,

I agree with your thinking here. We shouldn't be using a {{Path}} to the 
server-side, since we're supposed to handle {{Pathy}}-y things like the scheme 
and relative paths on the client. The NN should only be seeing absolute path 
strings.

Adding some new classes dealing in strings is likely the right call, though it 
does unfortunately increase the class-bloat. It's already kind of complicated 
having the similar-ish {{Directives}}, {{Descriptors}}, and {{Entries}}, and 
now we'll have 2 more (though both internal to HDFS). Internal complexity we 
can deal with, but simplifying all of this is an end-goal of mine.

> Refactor PathBasedCache* methods to use a Path rather than a String
> -------------------------------------------------------------------
>
>                 Key: HDFS-5224
>                 URL: https://issues.apache.org/jira/browse/HDFS-5224
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: datanode, namenode
>    Affects Versions: HDFS-4949
>            Reporter: Andrew Wang
>            Assignee: Chris Nauroth
>         Attachments: HDFS-5224.1.patch
>
>
> As discussed in HDFS-5213, we should refactor PathBasedCacheDirective and 
> related methods in DistributedFileSystem to use a Path to represent paths to 
> cache, rather than a String.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to