[ 
https://issues.apache.org/jira/browse/HDFS-5224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13788583#comment-13788583
 ] 

Chris Nauroth commented on HDFS-5224:
-------------------------------------

bq. I'm saying we add a method in DistributedFileSystem that takes a Path and 
returns a PathBasedCacheEntry initialized with the correct String (or a builder 
initialized with the correct string).

I had steered away from this approach, because it leaves clients getting a 
{{String}} instead of a {{Path}} when they call 
{{listPathBasedCacheDescriptors}}.  That would still be a bit of inconsistency 
in the interface.  (By analogy, {{listStatus}} returns {{FileStatus}}, which 
contains {{Path}}.)

While folks chew on this a little more, I'll get started on the builder code 
itself.  It sounds like everyone is in agreement on that part.


> Refactor PathBasedCache* methods to use a Path rather than a String
> -------------------------------------------------------------------
>
>                 Key: HDFS-5224
>                 URL: https://issues.apache.org/jira/browse/HDFS-5224
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: datanode, namenode
>    Affects Versions: HDFS-4949
>            Reporter: Andrew Wang
>            Assignee: Chris Nauroth
>         Attachments: HDFS-5224.1.patch
>
>
> As discussed in HDFS-5213, we should refactor PathBasedCacheDirective and 
> related methods in DistributedFileSystem to use a Path to represent paths to 
> cache, rather than a String.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to