[
https://issues.apache.org/jira/browse/HDFS-5224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13788466#comment-13788466
]
Andrew Wang commented on HDFS-5224:
-----------------------------------
Good idea, only change I'd like is to keep the directive immutable and use a
builder instead. We create the descriptor from the input directive in the
ClientNamenode PB translator, so it could possibly race here, and I don't think
mutating a directive after create time makes much sense anyway (esp after it's
used in {{addPathBasedCacheDirective}}).
> Refactor PathBasedCache* methods to use a Path rather than a String
> -------------------------------------------------------------------
>
> Key: HDFS-5224
> URL: https://issues.apache.org/jira/browse/HDFS-5224
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: datanode, namenode
> Affects Versions: HDFS-4949
> Reporter: Andrew Wang
> Assignee: Chris Nauroth
> Attachments: HDFS-5224.1.patch
>
>
> As discussed in HDFS-5213, we should refactor PathBasedCacheDirective and
> related methods in DistributedFileSystem to use a Path to represent paths to
> cache, rather than a String.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
