[
https://issues.apache.org/jira/browse/HDFS-5594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13843417#comment-13843417
]
Haohui Mai commented on HDFS-5594:
----------------------------------
The patch looks good to me overall. I have two minor comments:
# Why Acl#entries is a set? I'm wondering whether it should be ordered.
# It seems to me that guava's Objects.equal() and Objects.hashCode() could be
more efficient than Apache Common's EqualsBuilder() and HashCodeBuilder().
> FileSystem API for ACLs.
> ------------------------
>
> Key: HDFS-5594
> URL: https://issues.apache.org/jira/browse/HDFS-5594
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs-client
> Affects Versions: HDFS ACLs (HDFS-4685)
> Reporter: Chris Nauroth
> Assignee: Chris Nauroth
> Attachments: HDFS-5594.1.patch, HDFS-5594.2.patch, HDFS-5594.3.patch
>
>
> Add new methods to {{FileSystem}} for manipulating ACLs.
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
