[ https://issues.apache.org/jira/browse/HDFS-5594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13843457#comment-13843457 ]
Haohui Mai commented on HDFS-5594: ---------------------------------- bq. By including the perms in AclEntry#equals and AclEntry#hashCode, I haven't achieved that. I'm thinking of changing the set to something like Map<AclEntry.Key, FsAction> to better represent the unique constraint. Let me know if you agree, and I'll make the change. I'm wondering whether a compact representation, such as an arraylist might be better fit. This is because that there're relatively few ACLs, and checking the permissions is the dominant operation. Maybe it is a good idea is to spend the effort in addAcl() / removeAcl() to maintain the optimal orders to check the permissions efficiently. > FileSystem API for ACLs. > ------------------------ > > Key: HDFS-5594 > URL: https://issues.apache.org/jira/browse/HDFS-5594 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: hdfs-client > Affects Versions: HDFS ACLs (HDFS-4685) > Reporter: Chris Nauroth > Assignee: Chris Nauroth > Attachments: HDFS-5594.1.patch, HDFS-5594.2.patch, HDFS-5594.3.patch > > > Add new methods to {{FileSystem}} for manipulating ACLs. -- This message was sent by Atlassian JIRA (v6.1.4#6159)