[
https://issues.apache.org/jira/browse/HDFS-5594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13843820#comment-13843820
]
Vinay commented on HDFS-5594:
-----------------------------
Hi Chris, latest patch looks great. +1
I have some small concern, Not exactly about your patch.
Since you are touching FileSystem.java can clean following unused imports
{code}import java.util.Arrays;
import java.util.Collections;
import java.util.concurrent.atomic.AtomicInteger;{code}
One more thing, (general), why cant we check of trailing space in modified
lines using Hadoop QA? This is done in bookkeeper's QA.
> FileSystem API for ACLs.
> ------------------------
>
> Key: HDFS-5594
> URL: https://issues.apache.org/jira/browse/HDFS-5594
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs-client
> Affects Versions: HDFS ACLs (HDFS-4685)
> Reporter: Chris Nauroth
> Assignee: Chris Nauroth
> Attachments: HDFS-5594.1.patch, HDFS-5594.2.patch, HDFS-5594.3.patch,
> HDFS-5594.4.patch, HDFS-5594.5.patch
>
>
> Add new methods to {{FileSystem}} for manipulating ACLs.
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)