[
https://issues.apache.org/jira/browse/HDFS-5673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13863586#comment-13863586
]
Haohui Mai commented on HDFS-5673:
----------------------------------
bq. If that happens, then the whole request would get rejected anyway by the
duplicate entry check in AclTransformation#buildAndValidateAcl.
If I understand correctly, {{buildAndValidateAcl}} is executed at the very end
of the function. However, the constraints discussed above seem to be a
pre-condition of {{copyDefaultsIfNeeded}}, that is, the condition has to be met
in order for {{copyDefaultsIfNeeded}} to be executed correctly. It might be
worthwhile to add the check in {{copyDefaultsIfNeeded}} -- a simple way to
check it is to ensure {{userEntry}} has to be null during the assignment.
For FsPermission, I don't think I have enough information to conclude, I'm okay
with the current code, we can revisit it in the next patch.
> Implement logic for modification of ACLs.
> -----------------------------------------
>
> Key: HDFS-5673
> URL: https://issues.apache.org/jira/browse/HDFS-5673
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: namenode
> Affects Versions: HDFS ACLs (HDFS-4685)
> Reporter: Chris Nauroth
> Assignee: Chris Nauroth
> Attachments: HDFS-5673.1.patch, HDFS-5673.2.patch, HDFS-5673.3.patch,
> HDFS-5673.4.patch, HDFS-5673.5.patch
>
>
> This patch will include the core logic for modification of ACLs. This
> includes support for all user-facing APIs that modify ACLs. This will cover
> access ACLs, default ACLs, automatic mask calculations, automatic inference
> of unprovided default ACL entries, and validation to prevent creation of an
> invalid ACL.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
