[
https://issues.apache.org/jira/browse/HDFS-5673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13863671#comment-13863671
]
Chris Nauroth commented on HDFS-5673:
-------------------------------------
bq. It might be worthwhile to add the check in copyDefaultsIfNeeded – a simple
way to check it is to ensure userEntry has to be null during the assignment.
Now that the method has been recoded to use the binary search approach, this
check isn't exactly applicable. The binary search returns exactly one item,
and it's non-deterministic which one if there are duplicates. That means that
checking for a duplicate in {{copyDefaultsIfNeeded}} would require some kind of
forward and reverse scan from the binary search hit. Considering edge cases
like array out of bounds, I think this ends up being too awkward to be
worthwhile. I'm confident that we're catching these conditions in
{{buildAndValidateAcl}} due to unit tests that assert an exception when the
user tries to supply duplicate entries in the ACL spec.
> Implement logic for modification of ACLs.
> -----------------------------------------
>
> Key: HDFS-5673
> URL: https://issues.apache.org/jira/browse/HDFS-5673
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: namenode
> Affects Versions: HDFS ACLs (HDFS-4685)
> Reporter: Chris Nauroth
> Assignee: Chris Nauroth
> Attachments: HDFS-5673.1.patch, HDFS-5673.2.patch, HDFS-5673.3.patch,
> HDFS-5673.4.patch, HDFS-5673.5.patch
>
>
> This patch will include the core logic for modification of ACLs. This
> includes support for all user-facing APIs that modify ACLs. This will cover
> access ACLs, default ACLs, automatic mask calculations, automatic inference
> of unprovided default ACL entries, and validation to prevent creation of an
> invalid ACL.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
