[
https://issues.apache.org/jira/browse/HDFS-5167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13864598#comment-13864598
]
Jing Zhao commented on HDFS-5167:
---------------------------------
The latest patch looks pretty good to me. Some minors:
# The name of the NameNode retry cache may still need to contain "RetryCache".
This is because cacheName will be finally passed to
LightWeightGSet#computeCapacity, where a log will be recorded as
{code}
LOG.info("Computing capacity for map " + mapName);
{code}
How about assigning the name "NameNodeRetryCache" to FSNamesystem#retryCache,
and let RetryCacheMetrics#name be "RetryCache:"+ retryCache.getCacheName()?
# Can we have some unit tests to check the metrics along with the NameNode
retry cache? We can utilize HDFS-5118 to implement the unit tests.
# Nit: it will be better to add "if (LOG.isDebugEnabled())" in the constructor
of RetryCacheMetrics.
> Add metrics about the NameNode retry cache
> ------------------------------------------
>
> Key: HDFS-5167
> URL: https://issues.apache.org/jira/browse/HDFS-5167
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ha, namenode
> Affects Versions: 3.0.0, 2.4.0
> Reporter: Jing Zhao
> Assignee: Tsuyoshi OZAWA
> Priority: Minor
> Attachments: HDFS-5167.1.patch, HDFS-5167.2.patch, HDFS-5167.3.patch,
> HDFS-5167.4.patch, HDFS-5167.5.patch, HDFS-5167.6.patch, HDFS-5167.6.patch,
> HDFS-5167.7.patch, HDFS-5167.8.patch, HDFS-5167.9-2.patch, HDFS-5167.9.patch
>
>
> It will be helpful to have metrics in NameNode about the retry cache, such as
> the retry count etc.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
