[ 
https://issues.apache.org/jira/browse/HDFS-5167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13877346#comment-13877346
 ] 

Tsuyoshi OZAWA commented on HDFS-5167:
--------------------------------------

Thanks for your advice, [~jingzhao]. 

I've had some times to use LossyRetryInvocationHandler based on your advice. I 
also consulted TestLossyRetryInvocationHandler.java to use it. However, I still 
cannot use it. I appreciate if you can have a chance to answer my questions.

1.  I confirmed that TestLossyRetryInvocationHandler doesn't create 
LossyRetryInvocationHandler by using debugger. Is this assumed code path?
2.  I confirmed that we cannot use LossyRetryInvocationHandler just by setting 
DFSConfigKeys#DFS_CLIENT_TEST_DROP_NAMENODE_RESPONSE_NUM_KEY to positive. Is 
there missing point? 

My code which I'm developing is as follows: https://gist.github.com/oza/8536682

> Add metrics about the NameNode retry cache
> ------------------------------------------
>
>                 Key: HDFS-5167
>                 URL: https://issues.apache.org/jira/browse/HDFS-5167
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ha, namenode
>    Affects Versions: 3.0.0, 2.4.0
>            Reporter: Jing Zhao
>            Assignee: Tsuyoshi OZAWA
>            Priority: Minor
>         Attachments: HDFS-5167.1.patch, HDFS-5167.10.patch, 
> HDFS-5167.2.patch, HDFS-5167.3.patch, HDFS-5167.4.patch, HDFS-5167.5.patch, 
> HDFS-5167.6.patch, HDFS-5167.6.patch, HDFS-5167.7.patch, HDFS-5167.8.patch, 
> HDFS-5167.9-2.patch, HDFS-5167.9.patch
>
>
> It will be helpful to have metrics in NameNode about the retry cache, such as 
> the retry count etc.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to