[
https://issues.apache.org/jira/browse/HDFS-5940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13899704#comment-13899704
]
Colin Patrick McCabe commented on HDFS-5940:
--------------------------------------------
bq. Slap a @VisibleForTesting annotation for watcherThread
added
bq. BlockIdentifier javadoc refers to "BlockDescriptors"
fixed
bq. We might want to call it "ExtendedBlockIdentifier" since an ExtendedBlock
is what also has the bpid, but that is a mouthful. ExtendedBlockKey?
How about {{ExtendedBlockId}}? That seems short enough, and pretty accurate.
(By the way, {{ExtendedBlock}} itself has a bunch of other fields besides just
id and block pool id, and is not immutable, which is why I wanted the Id class
in the first place.)
> Minor cleanups to ShortCircuitReplica, FsDatasetCache, and DomainSocketWatcher
> ------------------------------------------------------------------------------
>
> Key: HDFS-5940
> URL: https://issues.apache.org/jira/browse/HDFS-5940
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs-client
> Affects Versions: 2.4.0
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Attachments: HDFS-5940.001.patch, HDFS-5940.002.patch
>
>
> ShortCircuitReplica#Key and FsDatasetCache#Key are pretty much identical code
> and should be factored out to an external class. (There will soon be a need
> for a third user of such an identifier.)
> Another minor cleanup is that DomainSocketWatcher should not implement
> Thread. It contains a thread currently, but I forgot to remove the "extends".
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
