[ 
https://issues.apache.org/jira/browse/HDFS-5940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13899720#comment-13899720
 ] 

Andrew Wang commented on HDFS-5940:
-----------------------------------

{{ExtendedBlockId}} sounds good. It sounds a bit like block id, but I think the 
javadoc and API make it pretty obvious that it also includes a bpid.

> Minor cleanups to ShortCircuitReplica, FsDatasetCache, and DomainSocketWatcher
> ------------------------------------------------------------------------------
>
>                 Key: HDFS-5940
>                 URL: https://issues.apache.org/jira/browse/HDFS-5940
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: hdfs-client
>    Affects Versions: 2.4.0
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>         Attachments: HDFS-5940.001.patch, HDFS-5940.002.patch
>
>
> ShortCircuitReplica#Key and FsDatasetCache#Key are pretty much identical code 
> and should be factored out to an external class.  (There will soon be a need 
> for a third user of such an identifier.)
> Another minor cleanup is that DomainSocketWatcher should not implement 
> Thread.  It contains a thread currently, but I forgot to remove the "extends".



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to