[ 
https://issues.apache.org/jira/browse/HDFS-5940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13900224#comment-13900224
 ] 

Hudson commented on HDFS-5940:
------------------------------

SUCCESS: Integrated in Hadoop-Yarn-trunk #480 (See 
[https://builds.apache.org/job/Hadoop-Yarn-trunk/480/])
HDFS-5940.  Minor cleanups to ShortCircuitReplica, FsDatasetCache, and 
DomainSocketWatcher (cmccabe) (cmccabe: 
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1567835)
* 
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/unix/DomainSocketWatcher.java
* 
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/unix/TestDomainSocketWatcher.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/BlockReaderFactory.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/ExtendedBlockId.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/client/ShortCircuitCache.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/client/ShortCircuitReplica.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetCache.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/TestEnhancedByteBufferAccess.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestBlockReaderLocal.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestShortCircuitCache.java


> Minor cleanups to ShortCircuitReplica, FsDatasetCache, and DomainSocketWatcher
> ------------------------------------------------------------------------------
>
>                 Key: HDFS-5940
>                 URL: https://issues.apache.org/jira/browse/HDFS-5940
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: hdfs-client
>    Affects Versions: 2.4.0
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>             Fix For: 2.4.0
>
>         Attachments: HDFS-5940.001.patch, HDFS-5940.002.patch
>
>
> ShortCircuitReplica#Key and FsDatasetCache#Key are pretty much identical code 
> and should be factored out to an external class.  (There will soon be a need 
> for a third user of such an identifier.)
> Another minor cleanup is that DomainSocketWatcher should not implement 
> Thread.  It contains a thread currently, but I forgot to remove the "extends".



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to