[
https://issues.apache.org/jira/browse/HDFS-6375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14005362#comment-14005362
]
Andrew Wang commented on HDFS-6375:
-----------------------------------
Took a look at the patch, I had a few review comments. Overall, it's definitely
the right idea, these are mostly just small things.
* Unrelated javadoc change in FileSystem
* Whitespace in DFSClient.java, could we align the exception classes like the
other methods in this file?
* Extra newline in DistributedFileSystem.java
* Whitespace change in PBHelper I think is unnecessary, it already looks
correct (double-indent)?
* I think it'd be better to make the internal client/server API pass XAttrs
with null values rather than Strings, since this way we can use the same
client-side code to turn them into strings. We basically would just return the
keys of the XAttrMap. This is also a more compact encoding since the namespace
is encoded as an enum.
Test:
* line with a whitespace only change
* typo: xaddr
* Would be good to see a test with the superuser, a normal user, and a trusted
xattr to test the filtering
* I personally prefer the style of static imports for asserts, IDEs often have
a short cut to do this for you
> Listing extended attributes with the search permission
> ------------------------------------------------------
>
> Key: HDFS-6375
> URL: https://issues.apache.org/jira/browse/HDFS-6375
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: namenode
> Affects Versions: 3.0.0
> Reporter: Andrew Wang
> Assignee: Charles Lamb
> Attachments: HDFS-6375.1.patch, HDFS-6375.2.patch, HDFS-6375.3.patch,
> HDFS-6375.4.patch, HDFS-6375.5.patch, HDFS-6375.6.patch
>
>
> From the attr(5) manpage:
> {noformat}
> Users with search access to a file or directory may retrieve a list of
> attribute names defined for that file or directory.
> {noformat}
> This is like doing {{getfattr}} without the {{-d}} flag, which we currently
> don't support.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
