[ 
https://issues.apache.org/jira/browse/HDFS-6375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14007943#comment-14007943
 ] 

Andrew Wang commented on HDFS-6375:
-----------------------------------

Real close, just a few more quick comments:

- indent is off in PBHelper
- JsonUtil still has toXAttrNames, can we do a similar change like in 
DFSClient, i.e. get the map of key/values, turn the keys into a list?
- Paranoia tests, could we also test listXAttr on a file that doesn't exist, 
and a file without any xattrs?

+1 pending these + Jenkins

> Listing extended attributes with the search permission
> ------------------------------------------------------
>
>                 Key: HDFS-6375
>                 URL: https://issues.apache.org/jira/browse/HDFS-6375
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: namenode
>    Affects Versions: 3.0.0
>            Reporter: Andrew Wang
>            Assignee: Charles Lamb
>         Attachments: HDFS-6375.1.patch, HDFS-6375.2.patch, HDFS-6375.3.patch, 
> HDFS-6375.4.patch, HDFS-6375.5.patch, HDFS-6375.6.patch, HDFS-6375.7.patch, 
> HDFS-6375.8.patch
>
>
> From the attr(5) manpage:
> {noformat}
>        Users with search access to a file or directory may retrieve a list  of
>        attribute names defined for that file or directory.
> {noformat}
> This is like doing {{getfattr}} without the {{-d}} flag, which we currently 
> don't support.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to